Skip to content

Added changes to support TWO-WAY Authentication while connecting to oracle DB while bringing up JRF domain #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2022
Merged

Added changes to support TWO-WAY Authentication while connecting to oracle DB while bringing up JRF domain #1181

merged 5 commits into from
Aug 25, 2022

Conversation

ganeshs05
Copy link
Member

Current implementation was not supporting TWO-WAY SSL while connecting to RCU schema on Oracle SSL DB.
Added changes to set properties to support the same while configuring WebLogic Domain.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Aug 24, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When singing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

jshum2479
jshum2479 reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the documentation update on this changes ? You should update

documentation/2.0/content/rcuinfo.md

jshum2479
jshum2479 reviewed Aug 24, 2022
View reviewed changes
core/src/main/python/wlsdeploy/tool/create/domain_creator.py Outdated
@@ -966,6 +967,32 @@ def __set_atp_connection_property(self, root_location, property_name, property_v
self.wlst_helper.set(wlst_name, wlst_value)

root_location.remove_name_token(property_name)

def __set_atp_connection_property_encrypted(self, root_location, property_name, property_value):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a positional parameter at the end of the function with default value (e.g. encrypted = False), then you don't have to duplicate the entire method. Then the caller only have to call with encrypted = True when needed. This avoid having duplicate code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding changes has been done and pushed please verify

@ganeshs05
Copy link
Member Author

Where is the documentation update on this changes ? You should update

documentation/2.0/content/rcuinfo.md

Documentation was already present for all trust/keystore properties...only properties required for TWO_WAY SSL DB communication was not set while creating weblogic domain

robertpatrick
robertpatrick requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@robertpatrick robertpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are adding functionality, you must update the documentation--either in this or a separate PR. We will consider this PR once we see the documentation changes.

rakillen
rakillen reviewed Aug 25, 2022
View reviewed changes
documentation/2.0/content/rcuinfo.md Outdated
domainInfo:
RCUDbInfo:
useSSL : true
rcu_db_conn_string: <reuired URL string for use with -run_rcu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*required - this is spelled "reuired" in 4 places, including old and new examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks for the review

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 25, 2022
@robertpatrick robertpatrick merged commit b600e41 into oracle:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshum2479 jshum2479 jshum2479 approved these changes

@robertpatrick robertpatrick robertpatrick approved these changes

@rakillen rakillen rakillen approved these changes

@ddsharpe ddsharpe Awaiting requested review from ddsharpe

+1 more reviewer

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ganeshs05 @jshum2479 @robertpatrick @rakillen @CarolynRountree